Add template provider #8504
Closed
Add template provider #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
template-provider
branch
from
d95581c to
65a74b1
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
|
||
| // New returns a new confmap.Provider that reads the template from a file. | ||
| // | ||
| // This Provider supports "file" scheme, and can be called with a "uri" that follows: |
There was a problem hiding this comment.
Is there any way to take advantage of the other providers to handle obtaining the templates? Since templates feel more like another type of config than a config "source" (file, http, s3, etc.), it would be unfortunate if templates could either only be obtained from select sources or that getting them from additional sources would require updates to the provider.
There was a problem hiding this comment.
Thanks for taking a look at this @evan-bradley. I worked out an implementation based only on a converter. (See #8507)
I actually like this a lot better.
- It has the advantage you mentioned, of allowing any provider to provide templates.
- It removes the awkward coupling between a provider and converter.
- It allows
templatesto appear directly in a config file (though I think typically they would not be used this way.) Still, it is nice to be able to reason about them in a more natural way.
Closed
|
Closing in favor of #8507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8372
This PR defines a new
templateprovider. It acts very similarly to thefileprovider but expects a "template" file as defined in #8372. It is not yet useful without an associated converter which will be needed to expand the template.Subset of #8344